Wikipedia:Bots/Requests for approval/JJMC89 bot 9

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was  Approved.

Operator: JJMC89 (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 04:16, Monday, January 30, 2017 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): Python

Source code available: Pending

Function overview: Replace BSicon redirects inside route diagram templates with the redirect target.

Links to relevant discussions (where appropriate): WP:BOTREQ#BSicons (permalink)

Edit period(s): Daily

Estimated number of pages affected: ~20,000 initially; varies afterward

Exclusion compliant: Yes

Already has a bot flag: Yes

Function details: Replace BSicon redirects inside route diagram templates with the redirect target.

• {{Routemap}}: Regex replace (\n|! !|!~|\\)%s(\n|!~|~~|!@|__|!_|\\) in |map='s value
• {{BS.*}}: Replace any parameter value that matches

The config has a blacklist and a whitelist.

This task was requested because the route diagram templates don't use syntax recognized by global replace / CommonsDelinker. — JJMC89 (T·C) 04:16, 30 January 2017 (UTC)[reply]

Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. — xaosflux ^Talk 05:56, 1 February 2017 (UTC)[reply]

Trial complete. 50 edits Replacements in {{Routemap}} are adding extra whitespace to the beginning and end of |map= (7/50 edits; e.g. 1, 2). This has no effect on visual display. I will look into the cause — |map= needs stripped or its a mwparserfromhell thing. — JJMC89 (T·C) 17:24, 1 February 2017 (UTC)[reply]

A simulation that ran over 2373 of the redirects would have edited 17,627 times, so the initial run may be ~20,000 edits. — JJMC89 (T·C) 17:24, 1 February 2017 (UTC)[reply]

Would the next admin to stop by please change the content model of config to JSON. Thanks. The config should also be ECP or TPROT at BAG's discretion. — JJMC89 (T·C) 18:08, 1 February 2017 (UTC)[reply]

Changed, set to ECP - if you want TPROT let me know. — xaosflux ^Talk 19:54, 1 February 2017 (UTC)[reply]

Thanks, it should be fine as ECP. {{Routemap}} whitespace issue fixed. — JJMC89 (T·C) 06:39, 2 February 2017 (UTC)[reply]

 Approved. with ramp-up schedule. You may use any slower schedule at your discretion. If you encounter minor issues, correct and restart the ramp up.

1. 1000 edits, 24 hr hold
2. 1000 edits, 24 hr hold
3. 3000 edits, 24 hr hold
4. Open editing. — xaosflux ^Talk 00:13, 5 February 2017 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.